Skip to content

WiFi.disconnect() "aligned with Aduino.cc". waiting for status change. #9062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

WiFi.disconnect() "aligned with Aduino.cc". waiting for status change. #9062

merged 1 commit into from
Jan 18, 2024

Conversation

JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented Jan 3, 2024 •
edited
Loading

WiFi.disconnect() "aligned with Aduino.cc".
WiFi.disconnect renamed to disconnectAsync
new WiFi.disconnect waits for status change

the WiFi library with async disconnect behaves very strange. after disconnect() and immediate WiFi.begin it can't connect. I had to add a wait for status change after disconnect in my test sketch.
So I think the blocking version of disconnect() is a better option for everybody. It is quick.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "WiFi.disconnect() "aligned with Aduino.cc". waiting for status change.":
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello JAndrassy, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8fa2724

@VojtechBartoska VojtechBartoska added Area: WiFi Issue related to WiFi Status: Review needed Issue or PR is awaiting review labels Jan 3, 2024
@TD-er
Copy link
Contributor

TD-er commented Jan 4, 2024

Just something to consider.
wl_status_t WiFiSTAClass::begin(const char* ssid, const char *passphrase, int32_t channel, const uint8_t* bssid, bool connect) is also calling esp_wifi_disconnect().
So instead of letting the user take care of async vs "waiting for' disconnect, shouldn't the begin() call take care of this?

Also all begin() calls do check for quite a lot of things but the only return state in case of an error is WL_CONNECT_FAILED.
Not really informative.

@JAndrassy JAndrassy force-pushed the wifi_disconnect_blocking branch 2 times, most recently from e728aad to 60876aa Compare January 17, 2024 21:13
@JAndrassy
Copy link
Contributor Author

JAndrassy commented Jan 17, 2024 •
edited
Loading

the state changes takes less than 1 millisecond.
disconnectAsync takes.2 milliseconds

@JAndrassy JAndrassy force-pushed the wifi_disconnect_blocking branch from 60876aa to 8daab72 Compare January 18, 2024 06:20
@JAndrassy JAndrassy force-pushed the wifi_disconnect_blocking branch from 8daab72 to 51af1c4 Compare January 18, 2024 08:18
@JAndrassy
WiFi.disconnect() "aligned with Aduino.cc". waiting for status change.
8fa2724 
WiFi.disconnect renamed to disconnectAsync

new WiFi.disconnect waits for status change
@JAndrassy JAndrassy force-pushed the wifi_disconnect_blocking branch from 51af1c4 to 8fa2724 Compare January 18, 2024 10:37
@me-no-dev me-no-dev merged commit 4766608 into espressif:master Jan 18, 2024
@JAndrassy JAndrassy deleted the wifi_disconnect_blocking branch January 18, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TD-er TD-er TD-er left review comments

@me-no-dev me-no-dev me-no-dev left review comments

Assignees
No one assigned
Labels
Area: WiFi Issue related to WiFi Status: Review needed Issue or PR is awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JAndrassy @TD-er @me-no-dev @VojtechBartoska